Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ReceiveMessage() return the most recent matching message #22

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

NoahAndrews
Copy link
Member

Without this PR, ReceiveMessage() is only guaranteed to return the most recent matching CAN frame if the mask is all 1s (0x1FFFFFFF). Otherwise, it will pick the most recent frame for whichever of the fully-matching arbitration IDs it happens to iterate to first.

This PR is needed to make https://github.com/REVrobotics/Desktop-Factory-Tester/pull/45 work correctly under all circumstances.

@NoahAndrews NoahAndrews merged commit 6917751 into main Nov 10, 2023
1 check passed
@NoahAndrews NoahAndrews deleted the return-latest-message branch November 10, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants